-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to skip schema inference - Archived #43
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devendrasr
changed the title
Support to skip schema inference along with reading iceberg tables having gzip compressed metadata files
Support to skip schema inference
Mar 8, 2024
…essed metadata json files
…ed_metadata Support to read gzip compressed metadata files
hey @devendrasr would you mind rebasing this PR on current main then push? That makes reviewing a little easier here |
…/duckdb_iceberg into feature/skip_schema_inference
Closing this pull request and renaming it to archived as I created a fresh and simplified pull request for this feature. @samansmink please review - #45 |
devendrasr
changed the title
Support to skip schema inference
Support to skip schema inference - Archived
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archived this one please refer - #45
The current version does not support complex data type parsing while inferring the schema from within the snapshot.
By the time support for complex data type comes, I am introducing a flag that can be used to skip this flow. This will offload schema parsing to the underlying parquet extension. Here is how you can do it -
scan data:
scan metadata:
scan snapshots:
Note - This PR is built on top of changes requested in the PR - #42